passing two variables with for loop

Hello,

I would like to do something like this:

PORTS="80 443"
TYPE'"TCP TCP"

for a in "PORTS" $TYPE"
do
iptables -A INPUT -p $a --sport $a -j ACCEPT
#this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT

done


I know that this is wrong.
Is there a way to do this with for loop.

Thanks

On 10/02/05 18:00, Bartosz Wegrzyn wrote:
> Hello,
>
> I would like to do something like this:
>
> PORTS="80 443"
> TYPE'"TCP TCP"
>
> for a in "PORTS" $TYPE"
> do
> iptables -A INPUT -p $a --sport $a -j ACCEPT
> #this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>
> done
>
>
> I know that this is wrong.
> Is there a way to do this with for loop.
>
> Thanks


Not exactly as you would but try this:

VARS="'tcp 80' 'tcp 443'"
for vars in $VARS ## assigns the 2 words within ' '
do
set $vars ## assigns two words to $1 and $2
iptables -A INPUT -p $1 --sport $2 -j ACCEPT
done

Ciao
Giovanni
--
A computer is like an air conditioner,
it stops working when you open Windows.
Registered Linux user #337974 <http://counter.li.org/>

Giovanni wrote:
> On 10/02/05 18:00, Bartosz Wegrzyn wrote:
>
>> Hello,
>>
>> I would like to do something like this:
>>
>> PORTS="80 443"
>> TYPE'"TCP TCP"
>>
>> for a in "PORTS" $TYPE"
>> do
>> iptables -A INPUT -p $a --sport $a -j ACCEPT
>> #this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>>
>> done
>>
>>
>> I know that this is wrong.
>> Is there a way to do this with for loop.
>>
>> Thanks
>
>
>
> Not exactly as you would but try this:
>
> VARS="'tcp 80' 'tcp 443'"
> for vars in $VARS ## assigns the 2 words within ' '
> do
> set $vars ## assigns two words to $1 and $2
> iptables -A INPUT -p $1 --sport $2 -j ACCEPT
> done
>
> Ciao
> Giovanni
thanks

Bartosz Wegrzyn <(E-Mail Removed)> writes:

>Hello,

>I would like to do something like this:

>PORTS="80 443"
>TYPE'"TCP TCP"

What is this second one supposed to mean? It has no closing single quote.


>for a in "PORTS" $TYPE"

And this is even worse. there are unballanced double quotes.

And you probably want $PORTS, not "PORTS"

>do
>iptables -A INPUT -p $a --sport $a -j ACCEPT
>#this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT

No it certainly would not translate to that. It would translate to
iptables -S INPUT -p 80 443 tcp -sport 80 443 -j ACCEPT
on the first run trough and to
nonesense on the second and third run through.


>done


>I know that this is wrong.
>Is there a way to do this with for loop.

What do you want to do?


>Thanks

Giovanni wrote:
> On 10/02/05 18:00, Bartosz Wegrzyn wrote:
>
>> Hello,
>>
>> I would like to do something like this:
>>
>> PORTS="80 443"
>> TYPE'"TCP TCP"
>>
>> for a in "PORTS" $TYPE"
>> do
>> iptables -A INPUT -p $a --sport $a -j ACCEPT
>> #this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>>
>> done
>>
>>
>> I know that this is wrong.
>> Is there a way to do this with for loop.
>>
>> Thanks
>
>
>
> Not exactly as you would but try this:
>
> VARS="'tcp 80' 'tcp 443'"
> for vars in $VARS ## assigns the 2 words within ' '
> do
> set $vars ## assigns two words to $1 and $2
> iptables -A INPUT -p $1 --sport $2 -j ACCEPT
> done
>
> Ciao
> Giovanni
actually this does not work
code is:

VAR="'a 1' 'b 2'"

for a in $VAR
do
set $a
echo "1:$1 2:$2"
done

output is
[root@localhost /]# sh new
1:'a 2:
1:1' 2:
1:'b 2:
1:2' 2:

Unruh wrote:
> Bartosz Wegrzyn <(E-Mail Removed)> writes:
>
>
>>Hello,
>
>
>>I would like to do something like this:
>
>
>>PORTS="80 443"
>>TYPE'"TCP TCP"
>
>
> What is this second one supposed to mean? It has no closing single quote.
>
>
>
>>for a in "PORTS" $TYPE"
>
>
> And this is even worse. there are unballanced double quotes.
>
> And you probably want $PORTS, not "PORTS"
>
>
>>do
>>iptables -A INPUT -p $a --sport $a -j ACCEPT
>>#this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>
>
> No it certainly would not translate to that. It would translate to
> iptables -S INPUT -p 80 443 tcp -sport 80 443 -j ACCEPT
> on the first run trough and to
> nonesense on the second and third run through.
>
>
>
>>done
>
>
>
>>I know that this is wrong.
>>Is there a way to do this with for loop.
>
>
> What do you want to do?
>
>
>
>>Thanks

i want this


VAR="'a 1' 'b 2'"

for a in $VAR
do
set $a
echo "1:$1 2:$2"
done

but the output is wrong

i was explecting "1:a 2:1" in first line but I got this

[root@localhost /]# sh new
1:'a 2:
1:1' 2:
1:'b 2:
1:2' 2:

On 10/02/05 20:06, Bartosz Wegrzyn wrote:
> Giovanni wrote:
>
>> On 10/02/05 18:00, Bartosz Wegrzyn wrote:
>>
>>> Hello,
>>>
>>> I would like to do something like this:
>>>
>>> PORTS="80 443"
>>> TYPE'"TCP TCP"
>>>
>>> for a in "PORTS" $TYPE"
>>> do
>>> iptables -A INPUT -p $a --sport $a -j ACCEPT
>>> #this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>>>
>>> done
>>>
>>>
>>> I know that this is wrong.
>>> Is there a way to do this with for loop.
>>>
>>> Thanks
>>
>>
>>
>>
>> Not exactly as you would but try this:
>>
>> VARS="'tcp 80' 'tcp 443'"
>> for vars in $VARS ## assigns the 2 words within ' '
>> do
>> set $vars ## assigns two words to $1 and $2
>> iptables -A INPUT -p $1 --sport $2 -j ACCEPT
>> done
>>
>> Ciao
>> Giovanni
>
> actually this does not work
> code is:
>
> VAR="'a 1' 'b 2'"
>
> for a in $VAR
> do
> set $a
> echo "1:$1 2:$2"
> done

Sorry I did not remember correctly. I answered without checking old
scripts :-(

for a in 'a 1' 'b 2' ## pairs are directly in the for statement
do
set $a
echo "1:$1 2:$2"
done

Ciao
Giovanni
--
A computer is like an air conditioner,
it stops working when you open Windows.
Registered Linux user #337974 <http://counter.li.org/>

Giovanni wrote:
> On 10/02/05 20:06, Bartosz Wegrzyn wrote:
>
>> Giovanni wrote:
>>
>>> On 10/02/05 18:00, Bartosz Wegrzyn wrote:
>>>
>>>> Hello,
>>>>
>>>> I would like to do something like this:
>>>>
>>>> PORTS="80 443"
>>>> TYPE'"TCP TCP"
>>>>
>>>> for a in "PORTS" $TYPE"
>>>> do
>>>> iptables -A INPUT -p $a --sport $a -j ACCEPT
>>>> #this would translate to iptables -A INPUT -p tcp --sport 80 -j ACCEPT
>>>>
>>>> done
>>>>
>>>>
>>>> I know that this is wrong.
>>>> Is there a way to do this with for loop.
>>>>
>>>> Thanks
>>>
>>>
>>>
>>>
>>>
>>> Not exactly as you would but try this:
>>>
>>> VARS="'tcp 80' 'tcp 443'"
>>> for vars in $VARS ## assigns the 2 words within ' '
>>> do
>>> set $vars ## assigns two words to $1 and $2
>>> iptables -A INPUT -p $1 --sport $2 -j ACCEPT
>>> done
>>>
>>> Ciao
>>> Giovanni
>>
>>
>> actually this does not work
>> code is:
>>
>> VAR="'a 1' 'b 2'"
>>
>> for a in $VAR
>> do
>> set $a
>> echo "1:$1 2:$2"
>> done
>
>
> Sorry I did not remember correctly. I answered without checking old
> scripts :-(
>
> for a in 'a 1' 'b 2' ## pairs are directly in the for statement
> do
> set $a
> echo "1:$1 2:$2"
> done
>
> Ciao
> Giovanni
can i do it indirectly

Bartosz Wegrzyn <(E-Mail Removed)> wrote:
>i want this
>
>VAR="'a 1' 'b 2'"
>for a in $VAR
>do
>set $a
>echo "1:$1 2:$2"
>done
>
>but the output is wrong
>
>i was explecting "1:a 2:1" in first line but I got this
>
>[root@localhost /]# sh new
>1:'a 2:
>1:1' 2:
>1:'b 2:
>1:2' 2:

You could probably use an array to do it, but here's another
way

VAR="A 1 B 2"


set $VAR
while [ $# -gt 0 ] ; do
echo "1:$1 2:$2"
shift;shift;
done

--
Floyd L. Davidson <http://www.apaflo.com/floyd_davidson>
Ukpeagvik (Barrow, Alaska) (E-Mail Removed)

Floyd L. Davidson wrote:
> Bartosz Wegrzyn <(E-Mail Removed)> wrote:
>
>>i want this
>>
>>VAR="'a 1' 'b 2'"
>>for a in $VAR
>>do
>>set $a
>>echo "1:$1 2:$2"
>>done
>>
>>but the output is wrong
>>
>>i was explecting "1:a 2:1" in first line but I got this
>>
>>[root@localhost /]# sh new
>>1:'a 2:
>>1:1' 2:
>>1:'b 2:
>>1:2' 2:
>
>
> You could probably use an array to do it, but here's another
> way
>
> VAR="A 1 B 2"
>
>
> set $VAR
> while [ $# -gt 0 ] ; do
> echo "1:$1 2:$2"
> shift;shift;
> done
>
thanks this works great