Badness in local_bh_enable at kernel/softirq.c:136

Hallo,

RaLink has written a kernel module as a driver for the WiFi cards
(mine is a miniPCI from MSI) using their chipset RT2560. People using
their module (source available at
http://www.ralinktech.com.tw/drivers...TA-1-4-0-0.zip,
but not GPL) on kernels 2.6.6 and upwards, experience very bad
performance, maybe because of tons of warnings found in
/var/log/messages, as in subject eg:

Badness in local_bh_enable at kernel/softirq.c:136
Call Trace:
[<c011bc42>] local_bh_enable+0x82/0x90
[<c02d2bd9>] dev_queue_xmit+0x219/0x2b0
[<c02e8710>] ip_finish_output+0xe0/0x230
[<c02e8986>] ip_mc_output+0x126/0x1a0
[<c02e98a6>] ip_generic_getfrag+0x46/0xb0
[<c02ea699>] ip_push_pending_frames+0x2b9/0x430
[<c02e9e86>] ip_append_data+0x576/0x730
[<c0306b02>] udp_push_pending_frames+0x142/0x240
[<c0306feb>] udp_sendmsg+0x3ab/0x6e0
[<c030ef7b>] inet_sendmsg+0x4b/0x60
[<c02ca862>] sock_sendmsg+0x92/0xb0
[<c0135a51>] buffered_rmqueue+0xf1/0x1b0
[<c01ebb10>] copy_from_user+0x50/0x80
[<c02ca305>] move_addr_to_kernel+0x35/0x50
[<c02cbd68>] sys_sendto+0xe8/0x110
[<c01ebb10>] copy_from_user+0x50/0x80
[<c02cc653>] sys_socketcall+0x173/0x240
[<c010403f>] syscall_call+0x7/0xb

I would like to know if this warning is caused by an error in the
driver, and if so, what we should be looking for.

Thanks for any advice,

Gerard

Gerard H. Pille wrote:
> Hallo,
>
> RaLink has written a kernel module as a driver for the WiFi cards
> (mine is a miniPCI from MSI) using their chipset RT2560. People using
> their module (source available at
> http://www.ralinktech.com.tw/drivers...TA-1-4-0-0.zip,
> but not GPL) on kernels 2.6.6 and upwards, experience very bad
> performance, maybe because of tons of warnings found in
> /var/log/messages, as in subject eg:
>
> Badness in local_bh_enable at kernel/softirq.c:136
> Call Trace:
> [<c011bc42>] local_bh_enable+0x82/0x90
> [<c02d2bd9>] dev_queue_xmit+0x219/0x2b0
> [<c02e8710>] ip_finish_output+0xe0/0x230
> [<c02e8986>] ip_mc_output+0x126/0x1a0
> [<c02e98a6>] ip_generic_getfrag+0x46/0xb0
> [<c02ea699>] ip_push_pending_frames+0x2b9/0x430
> [<c02e9e86>] ip_append_data+0x576/0x730
> [<c0306b02>] udp_push_pending_frames+0x142/0x240
> [<c0306feb>] udp_sendmsg+0x3ab/0x6e0
> [<c030ef7b>] inet_sendmsg+0x4b/0x60
> [<c02ca862>] sock_sendmsg+0x92/0xb0
> [<c0135a51>] buffered_rmqueue+0xf1/0x1b0
> [<c01ebb10>] copy_from_user+0x50/0x80
> [<c02ca305>] move_addr_to_kernel+0x35/0x50
> [<c02cbd68>] sys_sendto+0xe8/0x110
> [<c01ebb10>] copy_from_user+0x50/0x80
> [<c02cc653>] sys_socketcall+0x173/0x240
> [<c010403f>] syscall_call+0x7/0xb
>
> I would like to know if this warning is caused by an error in the
> driver, and if so, what we should be looking for.
>
> Thanks for any advice,
>
> Gerard
>
we just had to remove the WARN_ON on that line, and everything runs smoothly

it would still be interesting to know what is wrong